Inherit Jekyll's rubocop config for consistency #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is the result of adding inherit_gem:\n jekyll: .rubocop.yml to .rubocop.yml and running rubocop -a so that this project follows Jekyll core's coding styles for consistency like other core plugins. This way, as Jekyll's Ruby style changes, so too will this project's.
|
LGTM after a quick glance! @parkr Thoughts on this? Also, what's up with the failing builds? 😛 |
|
LGTM.
Failing build is caused by an annoying activesupport & html-pipeline
incompatibility with some Ruby versions. The Travis config here should be
overhauled, I think. Loosen `JEKYLL_VERSION=3.0.0` to `3.0` for starters.
|
|
What's left to do on this? Trigger a new build? (I tried by closing the PR ans reopening it but it didn't do the trick). |
|
If the tests are only failing on this branch, then we should update the Travis config here. :) |
|
Does #87 remove a block from this PR getting merged? |
Finished in 0.818618s, 20.7667 runs/s, 47.6413 assertions/s.
17 runs, 39 assertions, 0 failures, 0 errors, 0 skips/cc @jekyll/archives |
|
It's always funny looking at code you wrote a long time ago 😛 @jekyllbot: merge +dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of adding
inherit_gem: jekyll: .rubocop.ymlto.rubocop.ymland runningrubocop -aso that this project follows Jekyll core's coding styles for consistency like other core plugins. This way, as Jekyll's Ruby style changes, so too will this project's.