Enable incremental operation #58
Conversation
|
Thanks for the pull request! If I remember correctly, the reason I disabled incremental regen completely was because it still doesn't handle the case where posts are added—that is, while the archives page will be updated with your code, it will not be updated when a new post is created. |
|
I tested that case with this patch, works for me. |
|
Updated to only write the archives when they change. Bit of a messy commit history, sorry. |
|
@mnot Would you mind looking into the failures? |
|
@toolness this is really @alfredxing's domain 😄 |
|
@alfredxing I added the @jekyll/archives team which grants members write access to this repo. Feel free to invite anyone you wish! |
|
Oh lol, sorry, that was a brain fart on my part :) Thanks for working on this btw @mnot! Really really helpful PR. 😁 |
|
Please do have a good look through before you merge; while it works for me, I've also never really touched Ruby before, so I'm unfamiliar with the idioms, etc. |
|
We'd really love to implement this change in our project at 18F/beta.18f.gov. What's the status on this request? |
|
On the surface, this LGTM. |
|
Looks mostly good! Just one question: why keep track of dependencies for archive pages? Most likely we'll need |
|
That avoids regenerating all of your archives (e.g., all categories, all monthly archives back for however long, etc.) for each build. |
|
@mnot Is this still being worked on? |
|
I just took some time and tried out a bunch of scenarios with this patch, and everything seems good! However, I'm not 100% confident that this is going to work all of the time (without major bugs)... I'm thinking about maybe adding another config option (eww) to disable incremental regen? Not sure how you all feel about this (@parkr?) |
|
@alfredxing At this point, I'd say try it. Worst case scenario, they run a full rebuild and the problem ceases. Time to rip off the bandaid 😃 |
|
Okie! @mnot There are a couple of conflicts with my recent Page migration. I looked at them locally and they seemed easy to resolve. Can you rebase and take a look? 🙇 |
|
Sure. Might take a week or so, have a few things I need to do first. |
# Conflicts: # lib/jekyll-archives.rb # lib/jekyll-archives/archive.rb
|
Hmm, that problem with 1.9 seems to be an environment issue... |
|
@mnot You're right! I'd say we can drop support for Ruby 1.9 personally, but that's not really up to me here. @alfredxing can decide that. From the build error, it looks like we're trying to use Octokit 4.4.1, but Octokit 4.0 and above require Ruby 2.0 and above. |
|
Reading through this conversation, seems like there’s little preventing this PR being accepted. Would be nice to make this plugin compatible with incremental rebuilds. Any possibility of making the final push!? |
|
Let's get this show on the road. @alfredxing, I'm going to merge this for now. Please file any issues/PR's if you'd like to see anything here change. @jekyllbot: merge +minor |
I put this together quickly, seems to work for me. May need to track other dependencies.