Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jekyll dependency to be ~> 2.4 #23

Merged
merged 1 commit into from
Oct 5, 2014
Merged

Conversation

hazzik
Copy link
Contributor

@hazzik hazzik commented Oct 1, 2014

  • 8bbfaf6 used Utils.slugify which has been added in 2.4

@alfredxing
Copy link
Member

@parkr Comments? I think maybe changing it to ~> 2.4 (instead of ~> 2.4.0) might be better.

@parkr
Copy link
Member

parkr commented Oct 1, 2014

Once a project hits a major version (1.0, 2.0, etc), it should be pessimistically versioned at the MINOR level, as no breaking changes should be introduced in MINOR versions. ~> 2.4 is correct.

@alfredxing
Copy link
Member

Thanks for your input!
@hazzik Do you want to modify your PR a bit to make it ~> 2.4? Thanks for contributing!

* 8bbfaf6 used `Utils.slugify` which has been added in 2.4
@hazzik hazzik changed the title Change jekyll dependency to be ~> 2.4.0 Change jekyll dependency to be ~> 2.4 Oct 2, 2014
@hazzik
Copy link
Contributor Author

hazzik commented Oct 2, 2014

@alfredxing done

alfredxing added a commit that referenced this pull request Oct 5, 2014
Change jekyll dependency to be ~> 2.4
@alfredxing alfredxing merged commit 7ba071f into jekyll:master Oct 5, 2014
@alfredxing
Copy link
Member

Merged into HEAD. Thanks again!

alfredxing added a commit that referenced this pull request Oct 5, 2014
@hazzik hazzik deleted the patch-1 branch October 17, 2016 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants