Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing and using with Jekyll 4.x #133

Merged
merged 2 commits into from
Mar 23, 2019

Conversation

ashmaroli
Copy link
Member

Minimal changes to allow testing with Jekyll 4.0 pre-release.

(Should we drop support for Ruby 2.2 here for consistency?)

@ashmaroli ashmaroli requested a review from a team March 23, 2019 14:52
@mattr-
Copy link
Member

mattr- commented Mar 23, 2019

(Should we drop support for Ruby 2.2 here for consistency?)

We'll do this by default. Just because it might run on Ruby 2.2 now doesn't mean we'll actually support that use case (i.e. fix problems running on Ruby 2.2 when we break it) going forward.

@ashmaroli
Copy link
Member Author

@DirtyF I purposely avoided bumping the required_ruby_version in this PR..

@DirtyF DirtyF mentioned this pull request Mar 23, 2019
21 tasks
@DirtyF
Copy link
Member

DirtyF commented Mar 23, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 3996ee9 into jekyll:master Mar 23, 2019
jekyllbot added a commit that referenced this pull request Mar 23, 2019
@ashmaroli ashmaroli deleted the jekyll-4.0-support branch December 5, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants