Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue factoring frontend code out of the main app module #46

Open
kalilsn opened this issue Aug 22, 2022 · 0 comments
Open

Continue factoring frontend code out of the main app module #46

kalilsn opened this issue Aug 22, 2022 · 0 comments

Comments

@kalilsn
Copy link
Collaborator

kalilsn commented Aug 22, 2022

The core app.js file, which is the entrypoint for the whole frontend application, is almost 400 lines. There's a lot of logic in there that could be named and encapsulated in a function for readability. It also includes some anonymous functions that should be named.

We should break as much code as we can out of that module and name any discrete pieces of logic, purely for readability. We shouldn't do this until we've written tests for the existing functionality in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant