Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picker): 为当前选中的 picker-roller-item 新增类名 #3127

Merged
merged 1 commit into from
Jul 5, 2024
Merged

feat(picker): 为当前选中的 picker-roller-item 新增类名 #3127

merged 1 commit into from
Jul 5, 2024

Conversation

AnxysUaen
Copy link
Contributor

@AnxysUaen AnxysUaen commented Jul 4, 2024

这个 PR 做了什么? (简要描述所做更改)

为 Picker 组件备选项中的当前选中项新增 nut-picker-roller-item-selected 类名,便于为当前项配置自定义样式

这个 PR 是什么类型? (至少选择一个)

  • feat: 新特性提交
  • fix: bug 修复
  • docs: 文档改进
  • style: 组件样式/交互改进
  • type: 类型定义更新
  • perf: 性能、包体积优化
  • refactor: 代码重构、代码风格优化
  • test: 测试用例
  • chore(deps): 依赖升级
  • chore(demo): 演示代码改进
  • chore(locale): 国际化改进
  • chore: 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI H5 @nutui/nutui
  • NutUI Taro @nutui/nutui-taro

这个 PR 是否已自测:

Summary by CodeRabbit

  • 新功能
    • 添加了选择功能,通过当前索引来高亮显示选择项。

Copy link

coderabbitai bot commented Jul 4, 2024

Walkthrough

此更改在Column.vue中引入了一个新函数isCurrPick,用于基于当前索引进行选择高亮显示,并将该函数添加到导出的实体中。

Changes

文件路径 更改摘要
src/packages/.../Column.vue 引入并导出函数isCurrPick

Poem

小兔带来新功能,
isCurrPick闪亮舞动。
高亮选中更直观,
列表索引轻松查。
🎉📝✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 21ec9c8 and 6d03e06.

Files selected for processing (1)
  • src/packages/__VUE/picker/Column.vue (3 hunks)
Additional comments not posted (2)
src/packages/__VUE/picker/Column.vue (2)

27-28: 新增类名 nut-picker-roller-item-selected

此更改看起来是正确的。isCurrPick 函数用于确定当前项目是否被选中。


221-223: 新增 isCurrPick 函数。

此函数用于检查给定索引是否与当前索引匹配,逻辑简单且实现正确。

@AnxysUaen
Copy link
Contributor Author

#3106

@irisSong irisSong merged commit c52ab2b into jdf2e:v4 Jul 5, 2024
1 check passed
@AnxysUaen AnxysUaen deleted the patch-1 branch July 8, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants