Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogp:profile:first_name always results in a warning to stdout. #6

Open
berkes opened this issue May 11, 2020 · 0 comments
Open

ogp:profile:first_name always results in a warning to stdout. #6

berkes opened this issue May 11, 2020 · 0 comments

Comments

@berkes
Copy link

berkes commented May 11, 2020

Using profile type, as well as some other namespaced attributes, this OGP gem will always issue the warning Some og tag names include colons :, ... removed in the next major version.

The warning then pops up on e.g. logging and consoles. Since it is Kernel#warn, the consumer can disable it, so the problem is minor. Still, this is valid ogp and it is somewhat annoying to see those warnings pop up without being able to do anything about it, other than to disable warnings.

I assume, deprecating this, as announced in that warning, will result in a fix for this issue, so I don't present a PR for it.

If there is anything I can do to help fix this otherwise, or if it is desired to be fixed before it gets deprecated, (e.g. a gsub(':', '_')), please let me know and I'll do so in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant