Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LastModifiedCachingWireTest.java:62-69: Clean tests shared fields and... #161

Open
0pdd opened this issue Apr 26, 2017 · 1 comment
Open

Comments

@0pdd
Copy link

0pdd commented Apr 26, 2017

The puzzle 120-e6bf947f in src/test/java/com/jcabi/http/wire/LastModifiedCachingWireTest.java (lines 62-69) has to be resolved: Clean tests shared fields and redundant variables Move constants in this file to their tests because tests must share nothing. Then also inline any redundant variables. Please also configure pdd and est in.travis.yml as done e.g. in https://github.com/jcabi/jcabi-xml/blob/master/.travis.yml For first points explanation, read: http://www.yegor256.com/2016/05/03/test-methods-must-share-nothing.html http://www.yegor256.com/2015/09/01/redundant-variables-are-evil.html

The puzzle was created by Alan Evans on 18-May-16.

Estimate: 15 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD.

@0crat
Copy link

0crat commented Apr 26, 2017

@yegor256 please, pay attention to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants