Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS2 Discussion: Output: CS Octal/Binary Literal as ES2015? #4941

Closed
coffeescriptbot opened this issue Feb 19, 2018 · 3 comments
Closed

CS2 Discussion: Output: CS Octal/Binary Literal as ES2015? #4941

coffeescriptbot opened this issue Feb 19, 2018 · 3 comments

Comments

@coffeescriptbot
Copy link
Collaborator

From @Inve1951 on 2016-09-25 11:03

I'm bringing this up because nobody did so yet.

Numers in CS like 0b1010 and 0o31 currently compile to 0xa and 0x19 respectively.
Doing that conversion during compilation is no longer neccessary since those literals are now natively supported in JS.

Omitting that conversion and outputting as-is could slightly increase the ouput's readability or reveal intention.

@coffeescriptbot
Copy link
Collaborator Author

From @JimPanic on 2016-09-25 12:50

Since that literally means less code: awesome! ;D

On 25 Sep 2016, at 13:03, Inve1951 [email protected] wrote:

I'm bringing this up because nobody did so yet.

Numers in CS like 0b1010 and 0o31 currently compile to 0xa and 0x19 respectively.
Doing that conversion during compilation is no longer neccessary since those literals are now natively supported in JS.

Omitting that conversion and outputting as-is could slightly increase the ouput's readability or reveal intention.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@coffeescriptbot
Copy link
Collaborator Author

From @GeoffreyBooth on 2016-09-25 16:52

Yes, this makes sense.

@coffeescriptbot
Copy link
Collaborator Author

From @JimPanic on 2016-09-26 11:08

I submitted a PR to the 2 branch in the official repository. Feedback much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant