Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cmd does not fail when a good example returns errors #90

Closed
jamescooke opened this issue May 24, 2019 · 0 comments · Fixed by #91
Closed

make cmd does not fail when a good example returns errors #90

jamescooke opened this issue May 24, 2019 · 0 comments · Fixed by #91

Comments

@jamescooke
Copy link
Owner

As part of the test run, the tox command cmd runs make cmd. This runs the command line interface python -m flake8_aaa against all the good example files. If there is an error in the good examples, then an error will be returned:

=== examples/good/test_comments_aaa05.py ===
------+------------------------------------------------------------------------
 4 DEF|def test_arrange():
       ^ AAA01 no Act block found in test
 5 ???|    x = 3
 6 ???|    # Let's make a 3, 4, 5 triangle
 7 ???|    y = 4
 8 BL |
 9 ???|    sresult = x ** 2 + y ** 2
10 BL |
11 ???|    assert result == 25
------+------------------------------------------------------------------------
    1 | ERROR

This should then generate an error, and break tox, however it doesn't and tox returns OK:

  py36-cmd: commands succeeded
  congratulations :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant