Stencil buffer fix #2325
Merged
Stencil buffer fix #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codex128
reviewed
Oct 28, 2024
| frontStencilMask=state.frontStencilMask; | ||
| frontStencilReference=state.frontStencilReference; | ||
| backStencilMask=state.backStencilMask; | ||
| backStencilReference=state.backStencilReference; |
There was a problem hiding this comment.
Add spacing around '='.
| state.frontStencilMask=frontStencilMask; | ||
| state.frontStencilReference=frontStencilMask; | ||
| state.backStencilMask=backStencilMask; | ||
| state.backStencilReference=backStencilMask; |
There was a problem hiding this comment.
Add spacing around '='.
| state.frontStencilMask=additionalState.frontStencilMask; | ||
| state.frontStencilReference=additionalState.frontStencilMask; | ||
| state.backStencilMask=additionalState.backStencilMask; | ||
| state.backStencilReference=additionalState.backStencilMask; |
There was a problem hiding this comment.
Add spacing around '='.
|
Thanks for point out the spacing error. Since i added those values back in 2022, and the fix was already present in my local fork, it seems i forgot to commit them back then. As far i remember the original usecase used only Increment and NotEqual to 0 so it slipped trough the testing. |
codex128
approved these changes
Oct 28, 2024
stephengold
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the use of the stencil buffers.
As reference:
https://hub.jmonkeyengine.org/t/how-to-do-outline-with-stencil-buffer/47954/5
Also added the TestStencilOutline.java to the examples.
Note: Somehow the TestChooser app is overwriting the appsettings in the main method.
As a fix i added a postprocessor to the example application. This is not required when running
the test directly.