Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary remote repository fetches #9912

Closed
skshetry opened this issue Sep 5, 2023 · 0 comments · Fixed by #9925
Closed

unnecessary remote repository fetches #9912

skshetry opened this issue Sep 5, 2023 · 0 comments · Fixed by #9925
Assignees
@pmrowla
Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. performance improvement over resource / time consuming tasks regression Ohh, we broke something :-(

Comments

@skshetry
Copy link
Member

skshetry commented Sep 5, 2023

DVC has started cloning external repositories even on cases where it's not strictly required.
Anything that uses outs_graph has started cloning external repositories.

Commands like add/plots modify/pull/push/fetch/move are affected, and maybe potentially others.

Reproduce

git clone https://github.com/iterative/example-get-started.git
cd example-get-started
dvc add foo

Expected

No cloning occurs.
@skshetry skshetry added bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. performance improvement over resource / time consuming tasks regression Ohh, we broke something :-( labels Sep 5, 2023
@skshetry skshetry added this to DVC Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Sep 5, 2023
@skshetry skshetry moved this from Backlog to Todo in DVC Sep 5, 2023
@pmrowla pmrowla self-assigned this Sep 8, 2023
@pmrowla pmrowla mentioned this issue Sep 8, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in DVC Sep 8, 2023
@pmrowla pmrowla mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmrowla pmrowla

Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. performance improvement over resource / time consuming tasks regression Ohh, we broke something :-(
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repo: use is_repo_import to check for imports in outs_graph pmrowla/dvc
2 participants
@pmrowla @skshetry