-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: migrate to fsspec #6413
Comments
It seems like with some changes (see fsspec/filesystem_spec#731) passes all the functional tests against HTTP. I am now moving to the phase of running benchmarks, but some early microbenchmarks indicate that as is aiohttp is not as performant as requests when it comes to the threaded code. Still need to do more concrete examples (thinking about #6222 using as a benchmark case). |
I might've spoke a bit too soon, seems like it was causing due to a weird race which now is fixed but still it is not outperforming, but just catching up;
|
@isidentical, did you check with Line 11 in 13d1276
EDIT: Maybe not, I see that it has |
Also we directly use |
http
is an important remote, and we should migrate it to fsspec. There is already a built-in http filesystem insidefsspec
, but it seem to lack a couple of features we depend. So there should be some benchmarkings to determine whether we should create a sync,requests
backedhttpfs
or just use theHTTPFileSystem
from fsspec.The text was updated successfully, but these errors were encountered: