Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures that softwareVersion is a valid property #21

Closed
wants to merge 1 commit into from

Conversation

InternetRamen
Copy link

Fixes #20

This checks if softwareVersions exists, if not, add one.

@astagi astagi self-requested a review February 19, 2022 10:26
if (!doc.softwareVersion) {
doc.softwareVersion = tag || "v0.0.0";
yaml.dump(doc);
}
if (tag && doc.softwareVersion !== tag) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add softwareversion to yml, it won't get committed there ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add softwareVersion automatically if not present
2 participants