feat: Support nyc report --check-coverage #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 2, 2019
isaacs
force-pushed
the
report-and-check
branch
from
8a30a52 to
85e61ed
Compare
|
(force-pushed to fix lint error) |
coreyfarrell
reviewed
Feb 2, 2019
coreyfarrell
approved these changes
Feb 2, 2019
|
So does 2 approvals means it's cool for me to land this? I just realized I have write access on this org, but I don't wanna mess up any process. |
I just did it. For this PR a 'squash and merge' with the provided commit message was fine (you followed conventional-commit). I have no objection if you use 'squash and merge' for approved non-breaking changes as long as you make sure the commit message follows conventional-commit rules. For breaking changes I'd prefer that we have a chance to decide when those get landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.