-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #765 resolve custom cache directory to an absolute path #766
Conversation
9998662
to
e9767db
Compare
How's it look? |
@bcoe Anything else you want me to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
@mojavelinux 👍 I apologize for taking a long time to land this, I've been facing a family tragedy, and have just been starting to do a tiny bit of open-source work again. I'll get a candidate release of this out the door for you soon, so you can test things out. |
@mojavelinux try |
No need to apologize. I completely understand. My heartfelt condolences to you and your family, from your family in open source. ❤️ Thank you for taking the time away from your family to review and merge this change. |
Fix confirmed! |
Thanks again! While I now understand where nyc puts the cache by default, defining it explicitly in my package.json file makes me feel a lot more comfortable. I can now do that thanks to this fix: "nyc": {
"cache": true,
"cacheDir": "node_modules/.cache/nyc"
} |
No description provided.