Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #765 resolve custom cache directory to an absolute path #766

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

mojavelinux
Copy link
Contributor

No description provided.

@mojavelinux mojavelinux force-pushed the issue-765-cache-directory branch from 9998662 to e9767db Compare January 23, 2018 06:16
@mojavelinux
Copy link
Contributor Author

How's it look?

@mojavelinux mojavelinux changed the title resolves #765 resolve custom cache directory to absolute path resolves #765 resolve custom cache directory relative to absolute path Jan 26, 2018
@mojavelinux mojavelinux changed the title resolves #765 resolve custom cache directory relative to absolute path resolves #765 resolve custom cache directory to an absolute path Jan 26, 2018
@mojavelinux
Copy link
Contributor Author

@bcoe Anything else you want me to do?

@JaKXz JaKXz requested a review from bcoe February 6, 2018 04:27
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@bcoe bcoe merged commit dd48707 into istanbuljs:master Feb 13, 2018
@bcoe
Copy link
Member

bcoe commented Feb 13, 2018

@mojavelinux 👍 I apologize for taking a long time to land this, I've been facing a family tragedy, and have just been starting to do a tiny bit of open-source work again. I'll get a candidate release of this out the door for you soon, so you can test things out.

@bcoe
Copy link
Member

bcoe commented Feb 13, 2018

@mojavelinux try npm i nyc@next this update should have your changes.

@mojavelinux
Copy link
Contributor Author

No need to apologize. I completely understand. My heartfelt condolences to you and your family, from your family in open source. ❤️ Thank you for taking the time away from your family to review and merge this change.

@mojavelinux mojavelinux deleted the issue-765-cache-directory branch February 14, 2018 11:39
@mojavelinux
Copy link
Contributor Author

Fix confirmed!

@mojavelinux
Copy link
Contributor Author

Thanks again!

While I now understand where nyc puts the cache by default, defining it explicitly in my package.json file makes me feel a lot more comfortable. I can now do that thanks to this fix:

  "nyc": {
    "cache": true,
    "cacheDir": "node_modules/.cache/nyc"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants