Remove excluded files from coverage before writing #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581 by scrubbing the coverage object to remove any excluded files for which coverage was generated.
I'll admit to not being entirely sure how the coverage gets in for those files in the first place (the exclude logic appears to be running correctly in
addAllFiles()
), but this provides a catch-all at the end of processing to clean it up.There's also a question about whether the scrub should occur before or after following source maps. Doing it before seems to make the most sense based on how things work now.