Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to filter coveragemaps #637

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Conversation

schutm
Copy link
Contributor

@schutm schutm commented Jul 26, 2017

As dicussed in istanbuljs/istanbuljs#24

I found some time to recreate the implementation of this using sourcemaps. The sourcemaps made it way easier and it looks nicer as well now!

To reiterate why I made this: I've a 'non-standard' setup, where I build my distribution-packages outside of the source folder. I do this because I write mainly ES6 code, and distribution-packages need to be plain old JavaScript. In addition because AVA is perfectly able to run ES6 tests, but not able to test ES6 modules I've to transpile my ES6 code (using rollup and babel/bublé) to plain JavaScript. The resulting transpiled file will also include all libraries being imported.

In addition you can use this feature to make more specific reports. Instrument once, and split your reporting over different folders, or outputs. E.g. in the mono-repo have a HTML-report per library.

By filtering the coveragemaps for certain files, using include and exclude, it is possible to gain some more control over the files being included in the report. Normally this is done when instrumenting the code, but it may be beneficial to create different reports and instrument the code only once.
@schutm
Copy link
Contributor Author

schutm commented Jul 29, 2017

Anybody know how I can recheck this PR in appveyor. It seems to report the wrong status.

@bcoe
Copy link
Member

bcoe commented Aug 1, 2017

@schutm you can always just push an empty commit:

git push --allow-empty -m "make annoying appveyor be less annoying"

thanks for dusting this off.

@coveralls
Copy link

coveralls commented Aug 1, 2017

Coverage Status

Changes Unknown when pulling 2fd8674 on schutm:master into ** on istanbuljs:master**.

@bcoe bcoe merged commit dd40dc5 into istanbuljs:master Aug 22, 2017
@bcoe
Copy link
Member

bcoe commented Aug 22, 2017

@schutm thanks for the contribution, sorry it took so long to land!

I recently stood up a community slack here, to try to better coordinate work around the OSS projects Ive been managing:

http://devtoolscommunity.herokuapp.com/

would love to have you join, and help prod me into getting a new release of nyc out the door.

@bcoe
Copy link
Member

bcoe commented Sep 5, 2017

@schutm this is now released in [email protected] thanks for the contribution. I've already been testing things out, awesome work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants