From 54219b4fc11a9c8b3b0ae30e5c867b00f5e8a9ed Mon Sep 17 00:00:00 2001
From: isaacs <i@izs.me>
Date: Thu, 25 Jan 2024 16:41:22 -0800
Subject: [PATCH] ci: drop node 16

---
 .github/workflows/ci.yml | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c07063a..20af333 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -6,7 +6,7 @@ jobs:
   build:
     strategy:
       matrix:
-        node-version: [16.x, 18.x, 20.x, 21.x]
+        node-version: [8.x, 20.x, 21.x]
         platform:
           - os: ubuntu-latest
             shell: bash
@@ -25,11 +25,11 @@ jobs:
 
     steps:
       - name: Checkout Repository
-        if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
+        if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
         uses: actions/checkout@v3
 
       - name: Use Nodejs ${{ matrix.node-version }}
-        if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
+        if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
@@ -37,15 +37,10 @@ jobs:
       - name: debugging
         run: echo NODEVERSION=[${{ matrix.node-version }}] OS=[${{ matrix.platform.os }}]
 
-      # skip tests on node <16 on Windows, because npm install npm -g fails
-      - name: Use latest npm
-        if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
-        run: npm i -g npm@latest
-
       - name: Install dependencies
-        if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
+        if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
         run: npm install
 
       - name: Run Tests
-        if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
+        if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
         run: npm test -- -c -t0