Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a flag to enforce different types of behavior how to handle network peering implementation in lower levels #330

Open
balpert89 opened this issue Sep 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@balpert89
Copy link
Contributor

Summary

The current behavior dictates metalnetlet will reflect peering information into lower level types, e.g. https://github.com/ironcore-dev/metalnet/blob/main/api/v1alpha1/network_types.go#L20-L29. If there are other implementors of peering instead of metalnet the solutions will get in conflict with each other.

This issue proposes the introduction of a new typed string, NetworkPeeringControllingType:

type NetworkPeeringControllingType string

const (
    NetworkPeeringControllingTypeNative = "Native"
    NetworkPeeringControllingTypeNone = "None"
)

If unset or "Native" is passed, the current behavior is kept in place, such as metalnetlet will populate the peered prefixes for the lowlevel Network resources.

If "None" is passed, metalnetlet will not populate any peered prefixes for the metalnet-related Network resources.

The behavior should be introduced with a commandline flag, such as --network-peering-controlling-behavior.

@balpert89 balpert89 added the enhancement New feature or request label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant