Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reporting of files upload error #821

Closed
alanshaw opened this issue Sep 26, 2018 · 5 comments
Closed

Improve reporting of files upload error #821

alanshaw opened this issue Sep 26, 2018 · 5 comments
Assignees
Labels
exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@alanshaw
Copy link
Member

I have window.ipfs talking to an external js-ipfs daemon v0.32.

When I add a folder the button eventually changes to 100% and then I get a "Normal service is resumed" message. Files do not appear in the explorer.

@alanshaw
Copy link
Member Author

This is to do with the size of the upload, big files and folders do not work

@olizilla olizilla changed the title Files - add folder not working Improve reporting of files upload error Sep 27, 2018
@olizilla
Copy link
Member

I've reduced all errors down to "ipfs has gone", which is a bit too reductive. We need a custom notification for when file upload goes wrong. @hacdias put all the plumbing in place, but I was rushing, and disabled it. It needs to come back, but we can use the notify bundle to figure out what to show and when.

@olizilla olizilla added exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked labels Sep 27, 2018
@olizilla
Copy link
Member

There is the bigger issue that we have a bug with large or multiple file uploads, but that is a known issue. Web UI needs to do a good job of warning the user when problems occur.

@olizilla
Copy link
Member

File upload issue is documented here ipfs/kubo#5168

@olizilla
Copy link
Member

@fsdiogo could you take a look at the error reporting in Web UI pls. The notify bundle needs to be reworked so that it only tells the user that the connection to IPFS has failed when the bandwidth stats request fails. (that's not totally ideal, I know, but we poll it every 3s and we're using that to figure out when the daemon goes away in the connection bundle, so it's consistent at least)

Right now, we're taking all FETCH-*-FAILED redux actions to mean that connection was lost, but this isn't helpful as it smothers more specific errors. We should try and show things like "Failed to add file to IPFS" as there own specific notifications. Maybe start with that, but don't try and deal with all the error conditions in 1 PR, as it's a big job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

3 participants