-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use recursive gateways (HTTPGatewayRouter) as a fallback when other routers fails #665
Comments
I don't think we want to always fallback to recursive gateways.. but a solution that could get us the desired behavior is extending the Routers interface to support a priority key and then sorting on that prior to helia/packages/utils/src/routing.ts Line 60 in b723a1d
|
I think if we want to actually delay fallback routers we might need some changes other than just a priority key, since they’re all kicking off at essentially the same time.. |
You could add a delay to the |
I think users will want the fastest methods, but I think the motivation here is deprioritizing the use of recursive gateways, and trying to do all the work on the user side first. @lidel could speak more to primary motivations |
Primary motivation is to ensure users running with default settings (helia, verified-fetch) avoid hitting default recursive gateway when a direct provider is available. If custom recursive gateways are set by user, such user should be free to disable delay and make all methods race to get the fastest result. So maybe make that delay configurable (if not already)? I would go as far, as have constructor check if recursive gateway is one of public goods ( |
Background
Right now the Routing class, which wraps the different router implementations (of which are 3) treats all routers as equal, and calls them in parallel (by using the merge from
it-merge
):helia/packages/utils/src/routing.ts
Lines 57 to 60 in b723a1d
This means that if you have both:
delegatedHttpRouter
(with delegated routing endpoint)HTTPGatewayRouter
(for recursive gasteways),There is no programmatic way for your to prioritise direct retrieval over a recursive gateway.
Suggestion
In the following discussion, the idea of using
recursive gateways as a "last resort" fallback came up. This means that if direct retrieval fails (because there are no providers or because helia fails to retrieve directly from a provider), it falls back on the recursive gateway to fetch data.
The text was updated successfully, but these errors were encountered: