fix: webui on ipv6 localhost #7731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds localhost ipv6 addresses to the allowlist for use in browser context and fixes WebUI on ipv6-only deployments: http://[::1]:5001/webui We were missing CORS/Origin tests for API port so I've added basic ones and included localhost/127.0.0.1/::1 variants.
lidel
added
need/review
This was referenced Oct 19, 2020
Stebalien
approved these changes
Oct 26, 2020
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
fix: webui on ipv6 localhost This commit was moved from ipfs/kubo@0401f60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds localhost's ipv6 addresses to the Origin allowlist which is used in browser context, which fixes WebUI on ipv6-only deployments when loaded via
http://[::1]:5001/webuiWithout ip6 listed in
defaultLocalhostOriginswebui will fail with:We were missing CORS/Origin tests for API port, so I've added basic ones in
test/sharness/t0401-api-browser-security.shand includedlocalhost/127.0.0.1/::1variants to ensure webui works no matter what localhost notation is used.