fix(gw): preserve query on website redirect #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
approved these changes
Oct 14, 2020
aschmahmann
approved these changes
Nov 10, 2020
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
…bsite-redirect fix(gw): preserve query on website redirect This commit was moved from ipfs/kubo@0700c74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR preserves query parameters during internal redirect of http gateway and adds sharness test to guard against regression in the way
index.htmldetection works.Description of fixed problem
When
/foo?bar=buzwas requested and/foo/index.htmlexisted,gateway redirected to
/foo/and that redirect did not preserve query params.Problematic code was:
cc @mburns @hsanjuan