Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Range modifier for abci query #413

Closed
5 tasks
ethanfrey opened this issue Mar 16, 2019 · 0 comments
Closed
5 tasks

Add Range modifier for abci query #413

ethanfrey opened this issue Mar 16, 2019 · 0 comments

Comments

@ethanfrey
Copy link
Contributor

Currently we allow queries for one key or by prefix. Prefix queries use the Iterator function underneath, but only support a subset of possible queries, as it was simpler to define the interface at abci level. Let us expose this power.

  • define the arguments to range modifier (start, end, reverse?? More??)
  • define struct to be posted. Json? Protobuf? This goes into the binary data field for the abci query
  • add support for this struct with a new range modifier in orm.Bucket.Query
  • parse this struct in app.StoreApp.Query
  • update the AppHelper from the benchmark tests to make use of these query types to expose full ReadOnlyKVStore interface over abci.

And of course test this all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants