Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return iovns version info in abci_info #1

Open
davepuchyr opened this issue Apr 14, 2020 · 5 comments
Open

Return iovns version info in abci_info #1

davepuchyr opened this issue Apr 14, 2020 · 5 comments
Assignees
Labels

Comments

@davepuchyr
Copy link
Contributor

iov-one/weave#1194 was a really helpful feature that should be incorporated into iovns

@orkunkl
Copy link
Contributor

orkunkl commented Apr 15, 2020

Apparently we don't need extra implementation for this. Cosmos SDK handles it. Check related the configuration code:
http://github.com/iov-one/iovns/blob/4eacb6792f772669e4c6593a63949b8747a6f7d4/Makefile#L3-L12. Let's keep this issue here until we have a node running and test the issue.

@davepuchyr
Copy link
Contributor Author

{
  "jsonrpc": "2.0",
  "id": -1,
  "result": {
    "node_info": {
      "protocol_version": {
        "p2p": "7",
        "block": "10",
        "app": "0"
      },
      "id": "61e1f6d195f022cab0fe18f2ac1a4d33430999eb",
      "listen_addr": "tcp://0.0.0.0:26656",
      "network": "iovns",
      "version": "0.33.0",

...
I believe that "app": "0" means that we need the tech from iov-one/weave#1194.

@davepuchyr
Copy link
Contributor Author

@orkunkl, let's construct the app version info as 10000 * major + 100 * minor + patch, so v1.93.4 would yield app version 19304, for example.

@orkunkl
Copy link
Contributor

orkunkl commented Apr 22, 2020

I've made the implementation on cosmos-sdk but I'm sure even if we get this PR approved, it will take time to get this feature released soon. So instead we should fork cosmos-sdk as private repo and merge the changes there. @davepuchyr can you?

@davepuchyr
Copy link
Contributor Author

Let's wait until it's publicly announced that we're using cosmos-sdk.  I didn't know that it would be such a big deal to add this nice to have feature.  I know that it's unsatisfying to leave work in a "pending" state, but we want to stay in stealth mode until we can deliver to all of our stakeholders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants