-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return iovns version info in abci_info #1
Comments
Apparently we don't need extra implementation for this. Cosmos SDK handles it. Check related the configuration code: |
{
"jsonrpc": "2.0",
"id": -1,
"result": {
"node_info": {
"protocol_version": {
"p2p": "7",
"block": "10",
"app": "0"
},
"id": "61e1f6d195f022cab0fe18f2ac1a4d33430999eb",
"listen_addr": "tcp://0.0.0.0:26656",
"network": "iovns",
"version": "0.33.0", ... |
@orkunkl, let's construct the app version info as 10000 * major + 100 * minor + patch, so v1.93.4 would yield app version 19304, for example. |
I've made the implementation on cosmos-sdk but I'm sure even if we get this PR approved, it will take time to get this feature released soon. So instead we should fork cosmos-sdk as private repo and merge the changes there. @davepuchyr can you? |
Let's wait until it's publicly announced that we're using cosmos-sdk. I didn't know that it would be such a big deal to add this nice to have feature. I know that it's unsatisfying to leave work in a "pending" state, but we want to stay in stealth mode until we can deliver to all of our stakeholders. |
iov-one/weave#1194 was a really helpful feature that should be incorporated into
iovns
The text was updated successfully, but these errors were encountered: