Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Remove unnecessary #[wasm_bindgen] macros in wasm bindings #1407

Open
6 tasks
wulfraem opened this issue Sep 4, 2024 · 0 comments
Open
6 tasks

[Task] Remove unnecessary #[wasm_bindgen] macros in wasm bindings #1407

wulfraem opened this issue Sep 4, 2024 · 0 comments

Comments

@wulfraem
Copy link
Contributor

wulfraem commented Sep 4, 2024

Description

We have some class functions marked with #[wasm_bindgen] without any attributes. Those can be removed as long as the impl itself already has a wasm_bindgen macro, e.g. #[wasm_bindgen(js_class = Foobar)].

Motivation

Current state is not breaking, but removing the unnecessary macros cleans up the code a bit.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • The feature or fix is implemented in Rust and across all bindings whereas possible.
  • The feature or fix has sufficient testing coverage
  • All tests and examples build and run locally as expected
  • Every piece of code has been document according to the documentation guidelines.
  • If conceptual documentation (mdbook) and examples highlighting the feature exist, they are properly updated.
  • If the feature is not currently documented, a documentation task Issue has been opened to address this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant