You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have some class functions marked with #[wasm_bindgen] without any attributes. Those can be removed as long as the impl itself already has a wasm_bindgen macro, e.g. #[wasm_bindgen(js_class = Foobar)].
Motivation
Current state is not breaking, but removing the unnecessary macros cleans up the code a bit.
Change checklist
Add an x to the boxes that are relevant to your changes, and delete any items that are not.
The feature or fix is implemented in Rust and across all bindings whereas possible.
The feature or fix has sufficient testing coverage
All tests and examples build and run locally as expected
Every piece of code has been document according to the documentation guidelines.
If conceptual documentation (mdbook) and examples highlighting the feature exist, they are properly updated.
If the feature is not currently documented, a documentation task Issue has been opened to address this.
The text was updated successfully, but these errors were encountered:
Description
We have some class functions marked with
#[wasm_bindgen]
without any attributes. Those can be removed as long as the impl itself already has a wasm_bindgen macro, e.g.#[wasm_bindgen(js_class = Foobar)]
.Motivation
Current state is not breaking, but removing the unnecessary macros cleans up the code a bit.
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.The text was updated successfully, but these errors were encountered: