Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeLens does not display in val declaration #722

Closed
wk-j opened this issue Feb 26, 2018 · 8 comments
Closed

CodeLens does not display in val declaration #722

wk-j opened this issue Feb 26, 2018 · 8 comments
Labels
bug language services Problems related to language services - FSAC or FCS

Comments

@wk-j
Copy link

wk-j commented Feb 26, 2018

This is strange looking code because [<DefaultValue>] was separated by empty CodeLens line

localcontext_fs_ _captureservice

@Krzysztof-Cieslak Krzysztof-Cieslak added bug language services Problems related to language services - FSAC or FCS labels Feb 26, 2018
@7sharp9
Copy link
Contributor

7sharp9 commented Mar 12, 2018

I get this in a net standard project too, just a new console app with this type:

type LocalDbContext() =

  [<DefaultValue>]
  val mutable private test : int

@7sharp9
Copy link
Contributor

7sharp9 commented Oct 4, 2019

Screenshot 2019-10-04 at 15 37 35

Im getting a Lens with this ^

@7sharp9
Copy link
Contributor

7sharp9 commented Oct 4, 2019

Maybe the interim month have fixed this in FCS.

@Krzysztof-Cieslak
Copy link
Member

I’ll test that later today

@Krzysztof-Cieslak
Copy link
Member

I'm still not getting the code lenses for type signature and I'm getting wrong reference code lenses
image

In case of reference numbers (and I guess in the screenshot @7sharp9 posted) FSAC thinks that the symbol for which lens should be displayed is int rather than test

@7sharp9
Copy link
Contributor

7sharp9 commented Oct 7, 2019

If you take out the CR between the [<DefaultValue>] and val they seem to appear, I had to restart though.

@Krzysztof-Cieslak
Copy link
Member

As expected - this is indeed a bug in FCS, I've fixed that with dotnet/fsharp#10727 which means that in a few months time we will have this in Ionide.

@Krzysztof-Cieslak
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug language services Problems related to language services - FSAC or FCS
Projects
None yet
Development

No branches or pull requests

3 participants