Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Refine diagnosis for structs and enums #6

Open
scrabsha opened this issue Jul 7, 2021 · 0 comments
Open

Refine diagnosis for structs and enums #6

scrabsha opened this issue Jul 7, 2021 · 0 comments

Comments

@scrabsha
Copy link
Contributor

scrabsha commented Jul 7, 2021

Currently we emit a modification for the whole struct/enum if one of its token changes (source). This needs to be refined a bit.

The best solution would be to implement DiagnosticGenerator for StructMetadata and EnumMetadata, so that it handles things more cleanly.

It would also be a good idea to handle cases where an empty named struct is changed into an empty tupled struct (this is not a breaking change, see here).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant