build: Pass BSDmakefile args to gmake #1298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor convenience for platforms that doesn't have gmake installed but prefer the habit of writing make instead of gmake. test needs to live in .PHONY to get passed on to gmake.
jbergstroem
force-pushed
the
bsdmake_alias
branch
from
ecb693c to
495c03f
Compare
|
Hm... I guess it'll simplify the build process a lot :) LGTM, if it works. |
|
Thank you! |
|
"lgtm if it works" 😀 |
jbergstroem
added a commit
that referenced
this pull request
Apr 1, 2015
Minor convenience for platforms that doesn't have gmake installed but prefer the habit of writing make instead of gmake. test needs to live in .PHONY to get passed on to gmake. PR-URL: #1298 Reviewed-By: Fedor Indutny <[email protected]>
|
Merged in 5094a0f. Thanks for the review. Fyi - tested on FreeBSD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor convenience for platforms that doesn't have gmake installed but prefer the habit of writing make instead of gmake.
test needs to live in .PHONY to get passed on to gmake.
/R=@indutny?