Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker working group #1134

Closed
wants to merge 1 commit into from
Closed

Add Docker working group #1134

wants to merge 1 commit into from

Conversation

pesho
Copy link
Contributor

@pesho pesho commented Mar 13, 2015

/cc @iojs/tc

This is a request to establish a separate Docker working group. This is work that is already being done, and until now has been listed as a responsibility of the Build group. All members of Build who are also currently active contributors to the Docker images (@pesho, @wblankenship) will be among the initial members of the new group.

List of initial members:

@hmalphettes
@jlmitch5
@pesho
@Starefossen
@wblankenship

Also, it would be good to create a new GitHub team (@iojs/docker) with the initial members listed above, and given rights to manage https://github.com/iojs/docker-iojs

@pesho pesho mentioned this pull request Mar 13, 2015
Closed
bnoordhuis
bnoordhuis reviewed Mar 13, 2015
View reviewed changes
WORKING_GROUPS.md
@@ -177,6 +176,18 @@ Their responsibilities are:
The current members can be found in their
[README](https://github.com/iojs/roadmap#people).

### Docker

The Docker working group's purpose is to build, maintain, and improve official Docker images for the `io.js` project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: can you wrap lines at 80 columns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended, thanks.

@bnoordhuis
Copy link
Member

+1 FWIW.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 13, 2015

LGTM

@retrohacker
Copy link

👍

@chrisdickinson
Copy link
Contributor

LGTM, and thanks for your hard work!

@retrohacker retrohacker mentioned this pull request Mar 13, 2015
Merged
@rvagg rvagg mentioned this pull request Mar 18, 2015
Closed
@pesho
Copy link
Contributor Author

pesho commented Mar 30, 2015

So what happened here, guys? This was discussed at #1187. Is there a verdict?

@pesho pesho mentioned this pull request Mar 31, 2015
Open
@rvagg rvagg removed the tc-agenda label Apr 1, 2015
@pesho
Add Docker working group
fbcb109 
A new `Docker` working group is added to `WORKING_GROUPS.md`. Also, removed
the Docker images responsibility from the `Build` group's description.
@pesho
Copy link
Contributor Author

pesho commented Apr 1, 2015

Rebased and updated according to the changes in #1113

@Fishrock123
Copy link
Contributor

@rvagg I can't find the notes for this anywhere, shouldn't this still be tc-meeting?

@Fishrock123
Copy link
Contributor

Confirmed at today's TC (#1311) that it was approved.

@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Apr 4, 2015
@Fishrock123
Copy link
Contributor

Taking final responsibility for this. It was discussed in #1187 but the notes have not yet been PR'd.

Also, it would be good to create a new GitHub team (@iojs/docker) with the initial members listed above, and given rights to manage https://github.com/iojs/docker-iojs

@mikeal can you do that?

Fishrock123 pushed a commit that referenced this pull request Apr 4, 2015
@pesho @Fishrock123
doc: add Docker WG
679596c 
A new `Docker` working group is added to `WORKING_GROUPS.md`.
Also, removed the Docker images responsibility from the `Build`
group's description.

PR-URL: #1134
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-by: Chris Dickinson <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123
Copy link
Contributor

Landed in 679596c - Thanks for all your work, terribly sorry for the delay. :|

@Fishrock123 Fishrock123 closed this Apr 4, 2015
@pesho
Copy link
Contributor Author

pesho commented Apr 4, 2015

Thanks a lot @Fishrock123

Hoping to have a GitHub team for the WG soon as well (ping @mikeal @rvagg)

@retrohacker
Copy link

❤️ @Fishrock123

@Fishrock123 Fishrock123 mentioned this pull request Apr 4, 2015
Closed
@mikeal
Copy link
Contributor

mikeal commented Apr 5, 2015

created docker team with list of members from the README.

@pesho
Copy link
Contributor Author

pesho commented Apr 6, 2015

@mikeal the team needs permissions for the docker-iojs repository. Also, @hmalphettes and @jlmitch5 should be added as members.

@rvagg
Copy link
Member

rvagg commented Apr 6, 2015

docker-iojs added to the team, invites are already out to the two additions, they need to be accepted first.

@pesho
Copy link
Contributor Author

pesho commented Apr 6, 2015

Great, thanks ❤️

@pesho pesho deleted the patch-1 branch April 6, 2015 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pesho @bnoordhuis @cjihrig @retrohacker @chrisdickinson @Fishrock123 @mikeal @rvagg