Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make element id unique for proper grouping #338

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

viveksahu26
Copy link
Collaborator

We group by elementID to organize sections in ascending order and prioritize certain element IDs, like SBOM-related ones, at the top. Here, elementID is essentially the component name for packages or 'doc' for SBOM-level fields. A problem arises when multiple components with the same name but different versions are grouped under the same elementID, since identical names lead to unintentional grouping. Previously, this wasn’t an issue because elementID was set to unique identifiers like bom-ref, SPDXID, or component ID, which ensured uniqueness. To resolve this, I’ve now made elementID unique by combining component.name and component.version.

Previously

  • elementID = bom-ref, SPDXID, or component ID

Currently

  • elementID = component.Name

Now

  • elementID = component.Name + "-"+component.Version

Signed-off-by: Vivek Kumar Sahu <[email protected]>
@riteshnoronha riteshnoronha merged commit 3ef8e55 into interlynk-io:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants