make element id unique for proper grouping #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We group by
elementID
to organize sections in ascending order and prioritize certain element IDs, like SBOM-related ones, at the top. Here,elementID
is essentially the component name for packages or 'doc' for SBOM-level fields. A problem arises when multiple components with the same name but different versions are grouped under the sameelementID
, since identical names lead to unintentional grouping. Previously, this wasn’t an issue becauseelementID
was set to unique identifiers likebom-ref
,SPDXID
, or component ID, which ensured uniqueness. To resolve this, I’ve now madeelementID
unique by combiningcomponent.name
andcomponent.version
.Previously
bom-ref
,SPDXID
, or component IDCurrently
Now