Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/licenses #316

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Fix/licenses #316

merged 3 commits into from
Aug 21, 2024

Conversation

riteshnoronha
Copy link
Contributor

This PR fixes multiple issues

  1. is comp_valid_licenses correct? #309
  2. NTIA check for supplier was only checking supplier name, which is incorrect, it should check if supplier is present either name, url, or contact
  3. Updating license files from aboutcode & spdx.

@riteshnoronha
- Fixes license scoring
dc750fe 
- Fixes NTIA supplier name
- Updates SPDX & AboutCode licenses
surendrapathak
surendrapathak previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@surendrapathak surendrapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

surendrapathak
surendrapathak approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@surendrapathak surendrapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riteshnoronha riteshnoronha merged commit 053520f into main Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surendrapathak surendrapathak surendrapathak approved these changes

@viveksahu26 viveksahu26 Awaiting requested review from viveksahu26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riteshnoronha @surendrapathak