-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement golangci-lint feature and fix linter Errors #300
Merged
riteshnoronha
merged 11 commits into
interlynk-io:main
from
viveksahu26:fix_lint_errors
Aug 12, 2024
Merged
implement golangci-lint feature and fix linter Errors #300
riteshnoronha
merged 11 commits into
interlynk-io:main
from
viveksahu26:fix_lint_errors
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
riteshnoronha
previously approved these changes
Jul 30, 2024
@viveksahu26 need to resolve conflicts |
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Hey @riteshnoronha , any update on this ? |
@viveksahu26 lets resolve the conflicts then we can merge this in |
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Hey @riteshnoronha , merged conflict is resolved now !! |
riteshnoronha
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why we need this ?
This pull request introduces a comprehensive
golangci-lint
CI/CD pipeline setup to enforce coding standards and improve code quality across the project. Let's understand why we need this:To handle such errors golang provides wide range of linters i.e. 50+ linters such as
gofmt
,govet
, and many more mentioned here. But no one want to import each one of them in your package manually. Therefore, to solve this we have golangci-lint. It is the preferred Go linters aggregator that covers most the linters you’ll ever need. It runs these linters in parallel and reuses the build cache for improved performance during development.What changes are being made ?
golangci-lint.yaml
with configured linters and settings in a github worflow, which will be triggered on each PR made to the main branch.golangci-lint
ingolangci.yml
to include linting steps and all linters to process.Resources: