Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect soft dependencies #518

Open
pawelru opened this issue Mar 2, 2023 · 2 comments · May be fixed by #764 or #774
Open

Incorrect soft dependencies #518

pawelru opened this issue Mar 2, 2023 · 2 comments · May be fixed by #764 or #774
Assignees
Labels

Comments

@pawelru
Copy link
Contributor

pawelru commented Mar 2, 2023

We have moved some of the dependencies into Suggest but I think it was not a good call. As a result, when deploying an app that uses tmg modules, rsconnect is not able to identify app dependencies completely (it would not include package suggests). App developer needs to add explicit library calls into the app code but first of all he need to be aware of it (which is not very obvious). This is something we would like to avoid and keep the entry bar relatively low.

The trick about keeping dependencies in Suggests is not necessarily wrong but it has to be used only for soft dependencies so that the code is fully functional without a package. Great example can be found here. Here, we always calling stop() which indicates a hard dependency.

In order to fix it - let's move it back to be a hard dependency or make it a truly soft one.

As a direct consequence of this we have issues in teal.gallery and we had to add a lot of explicit library calls. Once fixed, please remove those.

@gogonzo
Copy link
Contributor

gogonzo commented May 23, 2024

I agree with Paweł 100%.

@kartikeyakirar kartikeyakirar self-assigned this May 27, 2024
@kartikeyakirar kartikeyakirar linked a pull request Jun 28, 2024 that will close this issue
@averissimo averissimo assigned averissimo and unassigned averissimo Jul 12, 2024
@averissimo averissimo self-assigned this Aug 14, 2024
@averissimo averissimo linked a pull request Aug 14, 2024 that will close this issue
@averissimo
Copy link
Contributor

Other than 1 (rlang) I don't think we can keep pkgs in Suggested without losing some features or visual functionality on plots.

The risk of this approach is a possible rejection from CRAN due to the long list of imports. PR #774 is up with the necessary changes

Image

If that's the case we can use @kartikeyakirar's PR #764 that disables some functionality or we can discuss an alternative approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants