Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should cdisc parent datasets have parents? #29

Open
cicdguy opened this issue Aug 5, 2021 · 2 comments
Open

Should cdisc parent datasets have parents? #29

cicdguy opened this issue Aug 5, 2021 · 2 comments

Comments

@cicdguy
Copy link
Contributor

cicdguy commented Aug 5, 2021

Do we need to limit the cdisc to only let datasets either have or be parents not both - or we need to change the getparent function to have an optional arg for getting all parents up the DAG otherwise cases like x has parent y has parent z and we filter on z in the filter panel and then use say only x in the cross table, the show r code will not give the same answer as it won't include the z filter

Provenance:

Creator: burkoffn
@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 5, 2021

If the filter panel does not work properly with long ancestry:

  1. fix the filter panel
    or
  2. limit the ancestry

Can we fix the filter panel easily?

Provenance:

Creator: kpagacz

@nikolas-burkoff
Copy link
Contributor

Let's not allow parents to have parents as we don't have user use cases which require this

@nikolas-burkoff nikolas-burkoff transferred this issue from insightsengineering/teal Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants