Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate blocksync and fastsync config options #1368

Open
conorsch opened this issue Oct 4, 2023 · 0 comments
Open

Deprecate blocksync and fastsync config options #1368

conorsch opened this issue Oct 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@conorsch
Copy link

conorsch commented Oct 4, 2023

Description

When running CometBFT v0.37.2 with a config file containing fastsync options, deprecation notices are printed:

I[2023-10-03|21:23:02.579] deprecated usage found in configuration file usage="[fastsync] table detected. This section has been renamed to [blocksync]. The values in this deprecated section will be disregarded."
I[2023-10-03|21:23:02.579] deprecated usage found in configuration file usage="fast_sync key detected. This key has been renamed to block_sync. The value of this deprecated key will be disregarded."

Renaming the fields as recommended causes config parsing via tendermint_config::TendermintConfig to fail:

Error: Failed to parse the TOML config template for CometBFT

Caused by:
    0: toml de error
       
       Caused by:
           missing field `fastsync` at line 457 column 1
       
       Location:

My understanding based on discussion in cometbft/cometbft#409 is that as of 0.38.x, neither blocksync nor fastsync options will be honored. I'm not sure how tendermint-config should handle this. Testing locally with CometBFT v0.38.0, neither errors nor warnings are emitted if the config file includes fastsync. However, it's still inappropriate that tendermint-config require the presence of an unused config option.

Definition of "done"

I see two options:

  1. tendermint_config::TendermintConfig supports blocksync fields, at least for <0.38
  2. Remove requirement for fastsync, making it optional.

with 2 being a bit easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant