Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS20 v2 Protobuf encoding #4098

Open
5 tasks
ljoss17 opened this issue Jul 23, 2024 · 0 comments · May be fixed by #4008
Open
5 tasks

ICS20 v2 Protobuf encoding #4098

ljoss17 opened this issue Jul 23, 2024 · 0 comments · May be fixed by #4008

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jul 23, 2024 •
edited
Loading

Summary

ICS20 v2 will encode packet data using Protobuf instead of JSON cosmos/ibc-go#6630.

Hermes will need to adapt the verification of memo and receiver fields to decode using Protobuf if the transfer is from ICS20 v2, https://github.com/informalsystems/hermes/blob/v1.10.0/crates/relayer/src/link/relay_path.rs#L1956.

Furthermore if the packet is a forward packet, the destination_memo, https://github.com/cosmos/ibc-go/blob/v9.0.0-beta.0/proto/ibc/applications/transfer/v2/packet.proto#L48, should be checked. If not the standard memo should be checked, https://github.com/cosmos/ibc-go/blob/v9.0.0-beta.0/proto/ibc/applications/transfer/v2/packet.proto#L38.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hermes
Status: 🩹 Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatibility for ICS20 v2 informalsystems/hermes
1 participant
@ljoss17