Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful messages when create client fails #1440

Closed
5 tasks done
Tracked by #1418
ancazamfir opened this issue Oct 8, 2021 · 1 comment · Fixed by #1450
Closed
5 tasks done
Tracked by #1418

Unhelpful messages when create client fails #1440

ancazamfir opened this issue Oct 8, 2021 · 1 comment · Fixed by #1450
Assignees
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Oct 8, 2021

Crate

relayer

Summary of Bug

Creating a client with trusting_period >= unbonding_period gives misleading information:

Error:
   0: foreign client error
   1: error raised while creating client for chain ibc-1: failed while querying src chain for latest height
   2: ICS 07 error
   3: invalid unbonding period

Version

master

Steps to Reproduce

Configure something like trusting_period = 28days in hermes config and run dev-env script. Try to create a client.
Output should be something like:

Error:
   0: foreign client error
   1: error raised while creating client for chain ibc-1: failed while building the client state
   2: ICS 07 error
   3: trusting period (28days) should be smaller than the unbonding period (21days)

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir
Copy link
Collaborator Author

ancazamfir commented Oct 11, 2021

Maybe also add a check for this during health-check to warn user if config's trusting_period >= chain's unbonding_period.

@romac romac self-assigned this Oct 11, 2021
@romac romac added this to the 10.2021 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants