Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous API with batching support #336

Closed
sjwang90 opened this issue Jun 23, 2022 · 0 comments · Fixed by #350
Closed

Synchronous API with batching support #336

sjwang90 opened this issue Jun 23, 2022 · 0 comments · Fixed by #350
Labels
enhancement New feature or request
Milestone

Comments

@sjwang90
Copy link

sjwang90 commented Jun 23, 2022

Proposal:
synchronous API with batching support

Current behavior:
async API is wrong-headed for Go

Desired behavior:

WriteAPIBlocking.WriteRecord could add stuff to a batch, and when the batch needs sending, it could send it. Adding a Flush method that may return an error from a previous write is sufficient, there doesn’t need to be any goroutines / channels at all. See e.g. https://pkg.go.dev/bufio#Writer.Flush

Alternatives considered:
Describe other solutions or features you considered.

Use case:
Why is this important (helps with prioritizing requests)?

@lesam

@vlastahajek vlastahajek added the enhancement New feature or request label Jul 19, 2022
@vlastahajek vlastahajek added this to the v2.10.0 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants