Add support for proto3 optional presence #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/hold
|
@MarcusLongmuir would appreciate a review on this. Thanks. |
|
Thanks for raising this @awbraunstein. @moadz is currently reviewing this. Will try to cut a release for this soon after it lands. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
improbable-prow-robot
added
the
approved
|
@MarcusLongmuir any chance to make a release containing this feature ? protoc 3.15.0 ships with it as a non-experimental feature. |
sxlijin
added a commit
to sxlijin/rules_typescript_proto
that referenced
this pull request
Mar 9, 2022
This was implemented in ts-protoc-gen in improbable-eng/ts-protoc-gen#275 and released nearly a year ago in [email protected]; glancing through the issue history it looks like the only reason this hasn't been bumped yet is because no one's tried to contribute it.
sxlijin
added a commit
to sxlijin/rules_typescript_proto
that referenced
this pull request
Mar 9, 2022
This was implemented in ts-protoc-gen in improbable-eng/ts-protoc-gen#275 and released nearly a year ago in [email protected]; glancing through the issue history it looks like the only reason this hasn't been bumped yet is because no one's tried to contribute it.
Dig-Doug
pushed a commit
to Dig-Doug/rules_typescript_proto
that referenced
this pull request
Mar 10, 2022
This was implemented in ts-protoc-gen in improbable-eng/ts-protoc-gen#275 and released nearly a year ago in [email protected]; glancing through the issue history it looks like the only reason this hasn't been bumped yet is because no one's tried to contribute it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add implementation for proto3 optional fields with presence tracking. Spec: https://github.com/protocolbuffers/protobuf/blob/master/docs/implementing_proto3_presence.md
Fixes: #263
Additionally, this change:
.bufferon the serialized message before passing intoBuffer.fromto handle a weird typescript issue.Verification
Tested via unit tests and visual inspection of generated files.