Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some initial implementation of gaussian blur, at the moment, it is more too have a look rather than merge.
This implementation is ~x20+ faster than current, faster than fast blur until radius goes reasonable huge (~50+) and will be probably faster than any other blur implementation (stack blur etc ) on low radius, with rayon it should even more effective, parallelization level of this algorithm is very high.
Here is some concerns:
sigma
something different, more like radius base instead of flattening levelGenericImageView
without explicit going unsafe; and even with unsafe I'm not sure I know best way to get direct typed buffer without copying.u8
storage type in mind, for other types performance variance is higherfilter_1d
, but at the moment only kernels with symmetry is handled properly. Are there some point to finalize it?ColorGroup
also is not common practice in this crate