Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Win32' as an alias of 'x86' #26

Closed
PazerOP opened this issue Mar 6, 2021 · 3 comments · Fixed by #29 or OpenDDS/OpenDDS#2473
Closed

'Win32' as an alias of 'x86' #26

PazerOP opened this issue Mar 6, 2021 · 3 comments · Fixed by #29 or OpenDDS/OpenDDS#2473

Comments

@PazerOP
Copy link

PazerOP commented Mar 6, 2021

There are quite a few bits during the setup and management of windows projects where your two options for architectures are Win32 and x64 instead of the more logical x86 and x64.

Is it possible that the arch parameter for this script could be made to also accept Win32 as an alias of x86 (and Win64 as x64 while we're at it)? This change would simplify some github actions scripts I have by a fair amount.

@PazerOP PazerOP changed the title Alias of x86 'Win32' as an alias of 'x86' Mar 6, 2021
@ilammy
Copy link
Owner

ilammy commented Mar 7, 2021

The parameters are meant to mirror MSVC's batch script to be more familiar (and easier to implement), but I see no reason why they must be limited to the values supported by the MSVC's batch script.

If that makes your life easier, I'd add them. The architecture names are a clusterfuck anyway, I don't see how a couple more would make things worse.

@ilammy
Copy link
Owner

ilammy commented Mar 7, 2021

I've just published v1.6.0 (aliased as v1) which should now accept win32 and win64 as aliases for x86 and x64 respectively. Matching is case-insensitive so win32, Win32, WIN32 are all the same.

@ilammy
Copy link
Owner

ilammy commented Mar 17, 2021

Since this seems to be working and @PazerOP reacted with “👍”, I guess we're done here.

@ilammy ilammy closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants