Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused variable in Shapes plugin #984

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 19, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Removed unused variable in Shapes plugin

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from chapulina as a code owner August 19, 2021 12:17
@ahcorde ahcorde self-assigned this Aug 19, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #984 (e112343) into ign-gazebo3 (7d1a3e0) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head e112343 differs from pull request most recent head 8bc6bc5. Consider uploading reports for the commit 8bc6bc5 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #984      +/-   ##
===============================================
+ Coverage        77.79%   77.84%   +0.04%     
===============================================
  Files              221      221              
  Lines            12687    12687              
===============================================
+ Hits              9870     9876       +6     
+ Misses            2817     2811       -6     
Impacted Files Coverage Δ
src/gui/plugins/shapes/Shapes.cc 31.25% <ø> (ø)
src/SimulationRunner.cc 94.49% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1a3e0...8bc6bc5. Read the comment docs.

@chapulina chapulina enabled auto-merge (squash) August 19, 2021 16:26
@chapulina chapulina merged commit d468c05 into ign-gazebo3 Aug 19, 2021
@chapulina chapulina deleted the ahcorde/shapes/unused_variable branch August 19, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants