[Dome] Add force focus when mouse enters render window #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
JShep1
changed the title
Signed-off-by: John Shepherd <[email protected]>
iche033
reviewed
Apr 28, 2020
Changelog.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ### Ignition Gazebo 4.X.X | |||
|
|
|||
| 1. Add window focus upon mouse entering the render window | |||
| * [Github pull request 97](https://github.com/ignitionrobotics/ign-gazebo/pull/97) | |||
There was a problem hiding this comment.
dome has not been release yet :) can you move this entry down to the 4.0.0 section?
Signed-off-by: John Shepherd <[email protected]>
iche033
approved these changes
Apr 28, 2020
Signed-off-by: John Shepherd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue mentioned here.
This PR focuses the render window if the mouse enters it. Previously, the render window was only focused if the user clicked it, introducing a slightly annoying behavior where the user had to click twice in order to use the snapping behavior given the
CTRLpress wouldn't be registered until after the window was focused.Signed-off-by: John Shepherd [email protected]