Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example: get an ECM snapshot from an external program #859

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Add an example program showing how to instantiate a copy of the ECM from another process. This makes use of the serialized state message, which can be acquired from the /state service or topic. This makes it convenient to access all entity and component data without the need for dedicated messages for each component type.

Test it

See the new README for instructions.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 16, 2021
@chapulina chapulina mentioned this pull request Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #859 (8b47a82) into ign-gazebo3 (5a3b1b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #859   +/-   ##
============================================
  Coverage        77.98%   77.98%           
============================================
  Files              216      216           
  Lines            12131    12131           
============================================
  Hits              9460     9460           
  Misses            2671     2671           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3b1b8...8b47a82. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to do the opposite? Set the ECM using a external program ?

@chapulina
Copy link
Contributor Author

Is there any way to do the opposite? Set the ECM using a external program ?

Interesting idea, we don't have a transport interface for that right now, but it could be added. It would be quite powerful though, so I think that would be geared towards advanced users.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 7c6c70a into ign-gazebo3 Jun 17, 2021
@chapulina chapulina deleted the chapulina/3/external_ecm branch June 17, 2021 21:50
@WagnerMarcos WagnerMarcos mentioned this pull request Jun 30, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants