Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view control gui plugin and support orthographic view #815

Merged
merged 4 commits into from
May 24, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 13, 2021

Summary

depends on gazebosim/gz-rendering#322

  • Updated view controller in Scene3d to support both orbit and orthographic view controller
  • Added View Control gui plugin that makes service request to Scene3D to toggle between the two view controllers

I can port the changes here to ign-gui if it helps in merging the two Scene3D classes.

To Test

Run ign-gazebo, open the GUI plugin menu (3 dots on top right) and select View Control plugin. Choose Orthographic from the drop down list to see the new view controller.

ortho_view_controller_gazebo

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@iche033 iche033 requested a review from chapulina as a code owner May 13, 2021 05:32
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 13, 2021
@nkoenig nkoenig self-requested a review May 13, 2021 16:03
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can port the changes here to ign-gui if it helps in merging the two Scene3D classes.

Thanks, yeah that will help. The current plan is to deprecate GzScene3D in Fortress (gazebosim/gz-gui#137).

@nkoenig
Copy link
Contributor

nkoenig commented May 13, 2021

Can you add ortho/perspsection control to the ViewAngle plugin instead of creating a new plugin?

@iche033
Copy link
Contributor Author

iche033 commented May 14, 2021

Can you add ortho/perspsection control to the ViewAngle plugin instead of creating a new plugin?

done, merged. 7218ef2

view_angle_control_gazebo

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 14, 2021
@scpeters scpeters removed the needs upstream release Blocked by a release of an upstream library label May 24, 2021
@iche033
Copy link
Contributor Author

iche033 commented May 24, 2021

The test failures look unrelated: level_manager, depth camera test, etc since the changes in this PR are limited to 2 GUI plugins. I think this is good to merge.

@iche033 iche033 merged commit ce50028 into main May 24, 2021
@iche033 iche033 deleted the ortho_view_control branch May 24, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants