-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add view control gui plugin and support orthographic view #815
Conversation
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can port the changes here to ign-gui if it helps in merging the two Scene3D classes.
Thanks, yeah that will help. The current plan is to deprecate GzScene3D
in Fortress (gazebosim/gz-gui#137).
Can you add ortho/perspsection control to the ViewAngle plugin instead of creating a new plugin? |
Signed-off-by: Ian Chen <[email protected]>
done, merged. 7218ef2 |
The test failures look unrelated: level_manager, depth camera test, etc since the changes in this PR are limited to 2 GUI plugins. I think this is good to merge. |
Summary
depends on gazebosim/gz-rendering#322
I can port the changes here to ign-gui if it helps in merging the two Scene3D classes.
To Test
Run ign-gazebo, open the GUI plugin menu (3 dots on top right) and select
View Control
plugin. ChooseOrthographic
from the drop down list to see the new view controller.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge