Fixed collision visual bounding boxes #702
Merged
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jenn Nguyen [email protected]
🦟 Bug fix
Summary
Encountered a new bug with collision visualizations. When collisions are turned on for a model, then any collision entity that was selected from the entity tree (which "highlights" the collision entity by putting a bounding box around it), will have bounding boxes around them once you turn off, then turn back on collisions. The only way to make the bounding boxes disappear is to select the collision entity again then deselect but once you turn collisions off then back on again for the model the bounding boxes reappear.
Steps to reproduce bug before PR:
ign gazebo -v 4 "https://fuel.ignitionrobotics.org/1.0/OpenRobotics/worlds/Edifice demo"
bar_1 and bar_2 should have bounding boxes around them.
If you run the above steps above with this PR, then the bounding boxes will not be shown around the collisions unless it is the most recent highlighted one from the entity tree. For example, if collisions are turned off and you select bar_2 from the entity tree then when you turn collisions back on (with bar_2 highlighted), bar_2 will have a bounding box around it.
This bug fix will need to be backported to
ign-gazebo4
for Dome.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge