-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add laser_retro support #603
Add laser_retro support #603
Conversation
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
…laser_retro Signed-off-by: Guillaume Doisy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this works for me! We just need an ign-rendering3
release before merging. Would it be possible to add an example world that exercises the feature? Just something simple with a box that has custom laser_retro
values and a sensor that captures it, and some instructions up top for the user to check the data? Thanks!
Sure, maybe an example in |
Yeah that works too! If adding one to this repository under examples/worlds isn't too much trouble, that's also a good place, since we've been putting many demos there. |
Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
686e36f
to
47a10d3
Compare
Done, hope it helps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me! We've made an ign-rendering
release.
Do you mind merging ign-gazebo3
into your branch so that the branch is up-to-date and CI is retriggered? It looks like I can't push to your branch.
Thanks!
Signed-off-by: Guillaume Doisy <[email protected]>
Ouch, still missing an |
@osrf-jenkins run tests please |
Hi @chapulina, would it be possible to do a release of ignition-gazebo3 in order to enjoy this PR from the standard binary installation? Thx! |
Sure, I'll see if I can get #534 in tomorrow and then trigger a release 👍 |
As discussed here gazebosim/gz-rendering#181, this is the last PR needed for complete laser_retro support