Use double sided field in material msg #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
chapulina
approved these changes
Jan 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 77.34% 77.38% +0.03%
==========================================
Files 213 213
Lines 11958 11952 -6
==========================================
Hits 9249 9249
+ Misses 2709 2703 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on gazebosim/gz-msgs#130
Addresses a todo items in Conversions.cc for serializing material data. A new
double_sidedfield is added in ign-msgs7 in gazebosim/gz-msgs#130 and this PR updates the conversion code to use that field.Signed-off-by: Ian Chen [email protected]